Skip to content

[Rules] Update execution order #21758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

[Rules] Update execution order #21758

merged 1 commit into from
Apr 16, 2025

Conversation

@pedrosousa
Copy link
Contributor

@pedrosousa pedrosousa commented Apr 16, 2025

Summary

Requested via internal chat.

@pedrosousa pedrosousa requested a review from a team as a code owner April 16, 2025 19:17
@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Apr 16, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

PR Change Summary

Updated the execution order of rules and clarified the behavior of terminating actions in the ruleset engine documentation.

  • Revised the execution order of various rules for clarity.
  • Clarified the behavior of terminating actions in the ruleset engine.
  • Added examples to illustrate how rule evaluation works.

Modified Files

  • src/content/partials/rules/product-execution-order.mdx
  • src/content/partials/ruleset-engine/rule-terminating-actions.mdx
How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Preview URL: https://2ec8094f.preview.developers.cloudflare.com
Preview Branch URL: https://pedro-2025-04-16-rules-update-order.preview.developers.cloudflare.com

@pedrosousa
Copy link
Contributor Author

pedrosousa commented Apr 16, 2025

Example page using the updated partials:
https://pedro-2025-04-16-rules-update-order.preview.developers.cloudflare.com/rules/origin-rules/#execution-order

@pedrosousa pedrosousa merged commit c3d34bc into production Apr 16, 2025
13 checks passed
@pedrosousa pedrosousa deleted the pedro/2025-04-16-rules-update-order branch April 16, 2025 19:35
RebeccaTamachiro pushed a commit that referenced this pull request Apr 21, 2025
@pedrosousa @RebeccaTamachiro
[Rules] Update execution order (#21758)
c39281d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kodster28 kodster28 kodster28 approved these changes

Assignees

@dcpena dcpena

@haleycode haleycode

@patriciasantaana patriciasantaana

Labels

size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pedrosousa @kodster28 @dcpena @haleycode @patriciasantaana